[Commands]: Add aria-activedescendant attribute to suggestions
#52930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +75 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add/aria-activedescendant-to-commands
branch
from
0f44dfd
to
0aee46e
Compare
|
Flaky tests detected in 0aee46e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5656203370
|
alexstine
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
@ntsekouras Thanks for the fix. Tested on Windows with Firefox and Chrome using NVDA.
alexstine
added
[Focus] Accessibility (a11y)
5 tasks
|
Thanks for working on this ❤️ @ntsekouras does it work with Safari and VoiceOver for you? For me, it does not. |
Yeah, for me it works 🤔 |
|
For me it still does not :( My env:
|
|
I have the same env and just tested in safari, where indeed it doesn't work. Probably related to the linked issue you shared.. I tested with Chrome and Firefox which is working as expected. |
|
Thanks for testing again @ntsekouras |
7 tasks
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #50846
From the issue:
Why?
This is a patch implementation outside the
cmdklibrary until the new version is released. When it does, we can remove this code and update the version. I followed the changes in cmdk PRTesting Instructions from the issue: