Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footnotes: disable for synced patterns and prevent duplication for pages in site editor #53003

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Footnotes: disable for synced patterns and prevent duplication for pages in site editor #53003

merged 6 commits into from
Aug 1, 2023

Commits on Jul 26, 2023

  1. Initial commit: 

    - Prevent footnote creation withing core/block
- Only insert a footnote if one isn't found in the entity block list
    @ramonjd
    ramonjd committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    165e6c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Try grabbing controlled blocks from parent post content block

    @andrewserong
    andrewserong committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f6087c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Cache selectedClientId 

    Get hasParentCoreBlocks using separate useSelect call.
    @ramonjd
    ramonjd committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    6fbe676 View commit details
    Browse the repository at this point in the history

  2. Rename hasParentCoreBlocks to isBlockWithinPattern 

    Add comments
    @ramonjd
    ramonjd committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2764baa View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Removing while loop since we're already fetching the post content par… 

    …ent in the `getBlockParentsByBlockName` call above
    @ramonjd
    ramonjd committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b22b26e View commit details
    Browse the repository at this point in the history

  2. Reinstating while loop because it can deal with nested blocks

    @ramonjd
    ramonjd committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f2f7194 View commit details
    Browse the repository at this point in the history