Changelog automation: use the correct label to filter Mobile app PRs #53024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priethor
added
the
[Type] Project Management
priethor
changed the title
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
getdave
reviewed
Jul 27, 2023
|
Flaky tests detected in a7ba2aa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5680114287
|
priethor
added
[Type] Project Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adapts the changelog automation script and its test fixtures to use the right label to filter out PRs related to the mobile app.
Why?
Mobile app-related PRs are not being filtered properly from the changelog.
How?
Instead of looking for a specific label, by filtering PRs that contain labels starting with the
Mobile Appprefix. This not only filters PRs with the updatedMobile App - i.e. Android or iOSlabel but also less frequent labels likeMobile App - ReleaseandMobile App - Automation.Testing Instructions
Run
npm run test:unit bin/plugin/commands/test/changelog.js. Three more PRs will be filtered out now.