fix: Select Gallery block when adding media #53127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Gallery block to mirror the behaviour of other blocks, e.g. the Image block. As a specific example, tapping "Add media" within an empty Gallery block now results in the Gallery block becoming the actively selected block.
dcalhoun
added
[Type] Bug
|
Size Change: +19 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
dcalhoun
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Select the Gallery block whenever it is focused.
Why?
Update the Gallery block to mirror the behaviour of other blocks, e.g.
the Image block. As a specific example, tapping "Add media" within an
empty Gallery block now results in the Gallery block becoming the
actively selected block. Fixes #38444.
This would also result in zero skipped tests for the mobile editor. 🎉
How?
Pass the
onFocusprop provided byBlockListBlockthrough the Gallery blockedit component onto the
MediaPlaceholder.Testing Instructions
Verify the mobile editor Gallery block receives selection on focus
Verify the web editor Gallery block has not regressed
Testing Instructions for Keyboard
n/a
Screenshots or screencast
gallery-focus-before.MP4
gallery-focus-after.MP4