Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding description of the --no-watch option #53139

Merged
merged 4 commits into from
Jul 30, 2023

Conversation

Armondal
Copy link
Contributor

What?

Adding description for the --no-watch option merged on February 2, 2023 and released in version 25.4.0 in packages/scripts/README.md and packages/scripts/CHANGELOG.md

Why?

Adds missing documentation on the --no-watch option merged on February 2, 2023 and released in version 25.4.0. See #44237 and #51695.

How?

Minor changes to documentation

Testing Instructions

Go to the scripts documentation.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 29, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Armondal! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Tool] WP Scripts /packages/scripts [Type] Developer Documentation Documentation for developers labels Jul 30, 2023
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a couple of small comments, but I think this PR makes sense 👍

@Armondal
Copy link
Contributor Author

ok I will update them soon

Armondal and others added 2 commits July 30, 2023 19:21
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@t-hamano t-hamano self-requested a review July 30, 2023 13:51
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would like to merge this PR once all the GitHub Actions tests have passed.

Thanks for your contribution 🎉

@t-hamano t-hamano merged commit 0cb48c2 into WordPress:trunk Jul 30, 2023
48 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Tool] WP Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants