Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Card component document #53172

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Update Card component document #53172

merged 1 commit into from
Aug 10, 2023

Conversation

bangank36
Copy link
Contributor

What?

  • Update Card component document in readme and storybook

Why?

  • Card component example provide some incorrect example code
  1. Text and Heading are imported incorrectly
  2. Heading prop size is used incorrectly, should be level

How?

  • Update readme and component document

Testing Instructions

  • Visit component component README
  • Visit component storybook stories

Testing Instructions for Keyboard

Screenshots or screencast

image

@bangank36 bangank36 requested a review from ajitbohra as a code owner July 31, 2023 11:15
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jul 31, 2023
@juanmaguitar juanmaguitar self-requested a review August 7, 2023 15:26
@bangank36 bangank36 mentioned this pull request Aug 10, 2023
Merged
@mirka mirka added the [Package] Components /packages/components label Aug 10, 2023
@mirka mirka merged commit 27f7eca into WordPress:trunk Aug 10, 2023
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmaguitar juanmaguitar juanmaguitar approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@bangank36 bangank36

Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.5
Development

Successfully merging this pull request may close these issues.
4 participants
@bangank36 @juanmaguitar @mirka @skorasaurus