Components: Restrict Popover focusOnMount to keyboard interaction #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Focus] Accessibility (a11y)
aduth
force-pushed
the
update/focus-on-mount-keyboard
branch
from
34445a6
to
c54b76c
Compare
Even on click, which no longer shifts focus as of 621631ca
aduth
force-pushed
the
update/focus-on-mount-keyboard
branch
from
c54b76c
to
b65d951
Compare
This was referenced Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2323
This pull request seeks to improve the behavior of
Popover'sfocusOnMountprop to apply only when the component mounts in response to a keyboard interaction. ThefocusOnMountprop (and itsFocusManagedcounterpart) are particularly useful for enabling a keyboard user to navigate contents of a popover after it's been opened. This behavior is not applicable for touch or pointer device users, and has historically caused some uncertainty, particularly in the editor menu where the focus styling effects can be mistaken for the selected item.Testing instructions:
Verify that
focusOnMountbehavior takes effect when navigating via keyboard.Verify that
focusOnMountbehavior does not take effect when navigating via touch or pointer device.