Refer to reusable blocks as 'Shared Blocks'

[noisysocks]

Closes #3810.

Makes the UI surrounding reusable blocks more consistent by referring to them as Shared Blocks. See #3810 and below for discussion on the name.

Internally and within the codebase we will still refer to them as reusable blocks—that name has stuck, I think.

For a regular block	For a reusable block

[jasmussen]

Change seems good!

It's unclear if there was any consensus on the name from #3810. I think Saved is fine, but CC @karmatosed and @melchoyce for input.

[melchoyce]

I keep calling them "shared blocks" by accident ¯_(ツ)_/¯

[karmatosed]

Saved works for me, although yes I have noticed myself saying 'shared'.. which is interesting.

[brandonpayton]

I think "Shared" is clearer. All block content is technically "Saved".

[jasmussen]

The blocks aren't shared between blogs in a multi site install, though, and I believe for security reasons they aren't even shared between authors on the same site. This is a confusion I had to explain on Twitter recently.

[brandonpayton]

@jasmussen I hadn't considered that. What do we think about the possibility of sharing between authors and even across sites in the future?

[jasmussen]

To my understanding that's not in the cards, as these are user created and it would be easy for a user to accidentally share private information. But cc @mtias and @pento as I'm sure they have more context.

[leahkoerper]

Until I read this I didn't actually realize that the Reusable/Saved blocks were in fact sharing information, e.g. an update on one would update the other instances. I had previously thought that the Reusable blocks were more like shortcuts you could drop into a post and tweak as needed, but that they were more or less individual entities once inserted into a post. Perhaps that's my bad for not paying attention but... I'd consider it a vote in favor of changing the name to Shared Blocks :)

[noisysocks]

It sounds like Shared is gelling more with everyone. I've updated the PR 🙂

[westonruter]

I also prefer “Shared Blocks” instead of “Saved Blocks”.

[jasmussen]

I disagree with the name "Shared" because they are only shared between posts by the same author, and "Shared" can imply that they can be shared across authors, perhaps even across sites.

However, this shed has been painted :) — and although I disagree, the time to test these things is now, and since it's a text change, there's no reason to hold things up. We can always revisit.

Feel free to go ahead and merge, and thank you for your work!

[pento]

I disagree with the name "Shared" because they are only shared between posts by the same author, and "Shared" can imply that they can be shared across authors, perhaps even across sites.

Sorry I didn't clarify this earlier. They are shared between all users with Contributor role and above, regardless of who the block author is.

See #4725 for related capabilities discussions.

[jasmussen]

Sorry I didn't clarify this earlier. They are shared between all users with Contributor role and above, regardless of who the block author is.

Well in that case, I rescind my disagreement, but maintain my 👍 👍 for merge :D

[gziolo]

What about file names? Should we update them, too?

[noisysocks]

Internally we're still referring to these things as reusable blocks. My feeling is that the name has traction within the team, e.g. in GitHub we have a Reusable Blocks label. Happy to go on a renaming spree if we think it's worth doing, though.

[pento]

Yeah, we should rename everything, as well. We won't be able to do it after merge, so better to do it before.

[mtias]

Yes, let's rename.

[carlhancock]

@pento @jasmussen With roles/capabilities coming into play on who can create/read/update/delete a block it means the issue that it's not obvious a block is a reusable/shared block unless you actually attempt to edit it becomes even more of an annoyance. Because now it's not obvious what is and isn't a reusable/shared block to be able to know what I can and cannot edit based on my user role.

It now means not only is it not obvious a block is reusable/shared without attempting to edit it, it also means there isn't a visual cue or UI element that makes it obvious that a block can or cannot be edited based on my role/capability. There should be a UI element such as an icon that makes it obvious that it is a reusable block AND another UI element such as a lock icon that makes it obvious that it is locked from allowing me to edit it.

See #5225.