Editor: Use hooks instead of HoCs for PostPingbacks
#53228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
added
the
[Priority] Low
|
Size Change: +7 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 1, 2023
Comment on lines
14
to
19
| const pingStatus = | ||
| useSelect( | ||
| ( select ) => | ||
| select( editorStore ).getEditedPostAttribute( 'ping_status' ), | ||
| [] | ||
| ) ?? 'open'; |
There was a problem hiding this comment.
Nit (non-blocking): What do you think about returning the default value from inside the mapSelect? For some reason, I found this pattern of useSelect() ?? defaultValue bit odd 😅
There was a problem hiding this comment.
Sounds good 👍 Moved in 08ae4a0
|
Flaky tests detected in 08ae4a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5726890781
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This straightforward PR updates the
PostPingbackscomponent to use the@wordpress/datahooks instead of the HoCs.Why?
A micro-optimization to makes the rendered component tree smaller.
How?
We're using the
useSelectanduseDispatchhooks instead of thewithSelectandwithDispatchhooks.Because we're removing a
withSelect, awithDispatchand acompose()instance, this removes 3 levels of nesting.Testing Instructions
Creating a new post and editing a new post, verifying the "Allow pingbacks & trackbacks" field under "Discussion" settings in the post sidebar still works well.
Testing Instructions for Keyboard
None.
Screenshots or screencast
The component tree before:
The component tree after:
