Mobile - KeyboardAwareFlatList - Avoid VirtualizedList console error #53237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latList component to avoid an error message, scroll is not actually needed within the FlatList since the ScrollView is the component that handles it
geriux
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 1cc77d8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5728430851
|
dcalhoun
reviewed
Aug 1, 2023
fluiddot
approved these changes
Aug 2, 2023
geriux
removed
the
Mobile App - Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR removes a console error related to nesting a VirtualizedList (FlatList) within a ScrollView in the KeyboardAwareFlatList component.
Why?
To avoid having to discard it constantly while developing.
How?
In React Native
0.71a new check was added for nested VirtualizedLists to avoid displaying the console error if it hadscrollEnabledset to false. For this case, the ScrollView is the component that handles the scrolling so we can disable it for the FlatList.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
VirtualizedListError.mov