Improve the efficiency of the useDebouncedInput hook #53263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +508 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
WunderBart
changed the title
|
Flaky tests detected in c310883. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5739064331
|
dmsnell
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
I don't have any thoughts here. I think the few places this is used we have strings as the values, so I think the performance should be the same. If you want, I can run the perf tests with something like 60 rounds, but this doesn't intersect the typing code so I wouldn't expect any patterns to appear.
Thanks for reviewing this code!
tyxla
approved these changes
Aug 2, 2023
mikachan
added
[Package] Block editor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the efficiency of the
useDebouncedInputhook by eliminating a redundant conditional check along with its dependency within theuseEffectfunction. React internally should handle it and avoid re-rendering if the value doesn't change.This is a slight improvement, so it might not be well reflected in the performance comparison tests as the metric value fluctuation is relatively high.
Testing Instructions