Fix Synced Patterns' color in quick inserter #53327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +780 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
glendaviesnz
reviewed
Aug 6, 2023
There was a problem hiding this comment.
Thanks for the fix @kevin940726 👍
This tests well for me. Unsynced pattern icons are the normal color while synced pattern icons are purple.
I also tested this after removing the additional sync status check and it continued to work as advertised.
aaronrobertshaw
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
After the latest tweak, this is looking good now. Still tests as advertised both manually and via unit tests.
Thanks @kevin940726 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix #53209. Fix the color for Synced Patterns in the quick inserter.
Why?
Consistency and clear separation.
How?
Use the
{ src, foreground }syntax for icons.Testing Instructions
patternand easy to distinguish between./patternand use the Arrow key to navigate through different patterns.Testing Instructions for Keyboard
Follow the same instructions above. Note that this fix changes the visual UI so it's not noticeable if you're only using screen readers.
Screenshots or screencast