Writing flow: fix vertical arrow keys not moving #53454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +17 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
LGTM!
From what I have been able to find, this problem also occurs in browsers other than Safari and seems to be affected by the initial cursor position, browser size, amount of scrolling, etc. I have also observed the problem not only with vertical but also horizontal movement.
For example, in my environment, I observed at least the following problems in trunk:
Chrome: get stuck when moving down
Screencast
chrome_vertical_down.mp4
Chrome: get stuck when moving right
Screencast
chrome_horizontal.mp4
Firefox: get stuck on both upward and downward movement
Screencast
firefox_vertical.mp4
I have tried various scenarios with this PR and everything seems to work as expected without stacking, both vertically and horizontally 🎉
chrome_result.mp4
|
Awesome! Yes, it seems like sometimes it works in Chrome, and sometimes is doesn't. I noticed it often gets stuck when the container is exactly aligned with the scroll container viewport 🤔 |
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #44055. Sometimes vertical arrow keys get stuck when the container edge is out of view.
Why?
How?
The problem lies in
isVerticalEdgewheredocument.caretRangeFromPointcan not get a Range in some browsers because it's out of view. The solution is to scroll the container into view like we do forplaceAtEdge.Testing Instructions
Vertical arrow key in Safari
Testing Instructions for Keyboard
Screenshots or screencast