Combine Document and Block Tools in the DOM #53494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
changed the title
|
Size Change: -10 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 233694d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5823360695
|
jeryj
added
the
[Focus] Accessibility (a11y)
|
@alexstine @joedolson I have the document tools and selected block tools wrapped together in the header as a proof of concept. A couple questions:
|
Escape key. This could cause screen reader mode changing on Windows until the iFrame is wrapped by
I do not see how a menubar could help us in changing toolbars but it is an option for menus. |
|
It was even suggested in the issue that maybe we simply combine other toolbars as well. For example, the image caption formatting bar gets combined with the image block toolbar. |
…erve all visual interactions This is a big commit with a large potential for bugs. Think of this as a spike or POC for now. There'll be a lot to address. Some general TODOs: - [ ] Refactor shared code between empty-block-inserter and selected-block-tools - [ ] More explicitly pass the popover slot and content ref into the SelectedBlockTools - [ ] Shortcut/keystrokes for returning from the toolbar to where the cursor was before moving into the toolbar - [ ] Inline Tools either move to the top toolbar or get inserted into the main block toolbar (think image caption formatting tools) - [ ] Visual styles for the top toolbar
…lbar on smaller screens
jeryj
force-pushed
the
refactor/combine-toolbars
branch
from
c659252
to
7e604d5
Compare
|
Closing in favor of #53779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large refactor/spike to test out how combining block tools in the DOM might be possible, as discussed in #53013. All mouse + visual placements should be the same.
This is a big commit with a large potential for bugs. Think of this as a spike or POC for now. There'll be a lot to address. Some general TODOs:
What?
Moving all Document and Block Tools together into the DOM.
Why?
How?
Moves Block Tools into the editor header
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast