Editor: updateEditorSettings: allow passing a callback #53516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +11 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7f0437c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5818785414
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
updateEditorSettingshas the potential to suffer from overriding existing settings, if you're not careful. This could happen if you get the existing settings and then callupdateEditorSettingsat a later point async, for example in auseEffect.Why?
Preventing race conditions.
How?
The solution is to allow passing a callback so settings can be merged synchronously, just like
useStateworks.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast