List View: Add keyboard shortcut for duplicating blocks #53559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
|
Size Change: +2.8 kB (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
andrewserong
changed the title
andrewserong
added
the
[Focus] Accessibility (a11y)
andrewserong
requested review from
kevin940726,
Mamaduka and
ellatrix
as code owners
andrewserong
removed
the
[Focus] Accessibility (a11y)
|
Hrm, looks like the altered e2e test is failing, even though it's passing locally. I'll look into it further. |
|
This PR makes it a whole lot more consistent when selecting multiple blocks, at least on Chrome, which shares that shortcut with the bookmark manager Before ⚰️2023-08-14.15.24.57.mp4After 🎉2023-08-14.15.26.41.mp4 |
|
Thanks for taking this for a spin @ramonjd!
Switching to |
|
What is the shortcut for Windows? |
|
@alexstine I believe the Windows shortcut will be Control + Shift + D, which should be the same as in the editor canvas. My Windows VM is playing up this morning so I haven't been able to test manually. Let me know if you run into any issues with it, though, and I can follow up. |
This sounds right! Just tested this branch on Edge + Windows 10. The following video demonstrates that the correct key mapping shortcut (Control + Shift + D) is displayed in the listview context menu. Also, using the shortcut duplicates the selected block. 2023-08-15.11.04.19.mp4 |
alexstine
reviewed
Aug 15, 2023
There was a problem hiding this comment.
@andrewserong Found one bug but otherwise, this is working well.
- Insert some blocks in the post editor.
- Open the list view.
- Duplicate a block with the keyboard shortcut.
- Notice how you are not moved to the duplicated block.
- Use the Duplicate option from the block Options menu.
- Notice how focus moves to the duplicated block.
Should the keyboard shortcut also move focus to the newly duplicated block?
|
Thanks for the detailed testing @alexstine! I've pushed an update, and I think the behaviour should now match what happens in the block options menu (focus is shifted to the duplicated block now). Let me know if you run into any further issues, of course. |
alexstine
approved these changes
Aug 18, 2023
|
Thanks for re-reviewing! |
25 tasks
38 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #49563
Within the List View, enable handling for the keyboard shortcut to duplicate blocks.
Why?
So that while navigating around the list view via keyboard, you can quickly duplicate the selected (or focused) blocks without needing to change focus to another area (i.e. the block settings menu or the editor canvas).
How?
Testing Instructions
CMD+Shift+dto duplicate the block. This should work!CMD+Shift+d— nothing should happen as only one Footnotes block is allowed on a post or page.Screenshots or screencast
In the below screengrab, Paragraph blocks are duplicated via the keyboard shortcut. Then, a selection that includes a Footnotes block is made, and the keyboard shortcut is attempted again, and nothing happens (which is expected).
2023-08-14.14.21.49.mp4