Post Editor: top-align Publish row in the post panel #53573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Package] Edit Post
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: +2 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on this comment
What?
This PR top-aligns the Publish row in the post sidebar.
Why?
In #53243, the row showing the sync state of the block pattern is now top-aligned. This PR may not be ideal, but I think that for rows that may wrap, the post date row should be aligned on top as well as the URL row and the sync row.
How?
Apply
align-items: startto the row. At the same time, the height of the toggle button to change the post date has been changed toauto. There is a 6px padding above and below this button, but if the height is fixed at 36px, the text will intervene in the padding area and not be aligned at the correct height.This would make this button slightly taller than before. However, I find this acceptable, since the same is true for the URL button with
height:autospecified.Testing Instructions