Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the documented type for the $w parameter of block_core_navigation_add_directives_to_submenu() #53585

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

johnbillion
Copy link
Member

@johnbillion johnbillion commented Aug 11, 2023

What?

This correct the docblock for block_core_navigation_add_directives_to_submenu() which incorrectly documents the $w parameter as a string.

@johnbillion johnbillion added the [Type] Developer Documentation Documentation for developers label Aug 11, 2023
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aristath aristath force-pushed the WP_HTML_Tag_Processor branch from b22f099 to 9e4a2be Compare October 9, 2023 11:02
@aristath
Copy link
Member

aristath commented Oct 9, 2023

@johnbillion This PR was stale and there was a conflict with trunk.
I rebased it, so once tests pass we'll be able to merge it 👍

@aristath aristath enabled auto-merge (squash) October 9, 2023 11:03
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Flaky tests detected in 9e4a2be.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6455731108
📝 Reported issues:

@aristath aristath merged commit 5cf045d into trunk Oct 9, 2023
50 checks passed
@aristath aristath deleted the WP_HTML_Tag_Processor branch October 9, 2023 11:50
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants