Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: bundle WP_REST_Global_Styles_Controller class instead of inheriting per WordPress version #53618

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Try: bundle WP_REST_Global_Styles_Controller class instead of inheriting per WordPress version #53618

merged 5 commits into from
Aug 14, 2023

Commits on Aug 14, 2023

  1. Bundles global styles controller code into one file to avoid conflict… 

    …s and ensure the response always reflects changes from WP_Theme_JSON_Gutenberg
    @ramonjd
    ramonjd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    535b48a View commit details
    Browse the repository at this point in the history

  2. Registering routes

    @ramonjd
    ramonjd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    96d0bd0 View commit details
    Browse the repository at this point in the history

  3. Empty line required before block comment 

    Apparently
    @ramonjd
    ramonjd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    89af152 View commit details
    Browse the repository at this point in the history

  4. There is a fight to the death between the "Empty line required before… 

    … block comment" and "Empty lines are not allowed in multi-line function calls" rules.

Which one will prevail?

For now just use single line comments to shut them both up.
    @ramonjd
    ramonjd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ebb730c View commit details
    Browse the repository at this point in the history

  5. Whoops. Forgot to import the rest-api.php file 

    Rename unit test
    @ramonjd
    ramonjd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    111c7e0 View commit details
    Browse the repository at this point in the history