-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High priority fixes for 6.3.1 #53709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move editor style logic into a hook whith useMemo * Remove unnecessary useMemo * Move the whole logic inside the 'useMemo' * Add missing useSelect dep --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
* Footnotes: fix accidental override * Remove double quotes
* Footnotes: autosave saves decoded JSON * wp_slash * Curly quote * Slash on save and restore
tellthemachines
requested review from
kevin940726,
Mamaduka,
ajitbohra and
nerrad
as code owners
August 16, 2023 02:00
Size Change: +51 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested commits
For those that I couldn't test. e.g., #53596 confirmed that code is present and editor is working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a few issues that are causing editor crashes in 6.3.
Includes the following PRs:
Footnotes: Fix recursion into updating attributes when attributes is not an object
Footnotes: autosave is not slashing JSON
Footnotes: fix accidental override
Footnotes: checking type before using count()
Fix crash by moving editor style logic into a hook with useMemo
Testing Instructions
Follow instructions for each PR.
Testing Instructions for Keyboard
Screenshots or screencast