Edit Post: Fix tab border conflicts in the Document Overview panel #53711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 16, 2023
|
Thanks for the review!
I agree with you on this point. However, in #52997, it appears that the introduction of tab panel v2 is being considered. As for being fixed at the component level, I believe that we can do that when we actually incorporate this v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53651
What?
This PR fixes a conflict between the active and gray borders of the tab panel in the document overview sidebar.
Before
After
Why?
For consistency with other tab panels.
How?
I have added a negative bottom margin below the tab button to overlap the active border and the gray border. You can find several examples of this approach by searching the code with
margin-top: -$border-width;ormargin-bottom: -$border-width;.As a result, the tab content is moved up by 1px. To maintain the previous height, I have increased the height of the content by 1px.
Testing Instructions