[RNMobile] Add optional chaining to reusableBlock.title
#53721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds safety checks for the `title` property within `reusableBlock`. By using optional chaining, the code now gracefully handles scenarios where `title` might be undefined, preventing a TypeError from being thrown.
SiobhyB
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
|
Flaky tests detected in abb51ba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5876946940
|
geriux
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
LGTM!
Adding this optional chaining makes sense to me, as you mentioned there are other places with the same approach 👍.
It's hard when we have these kinds of crashes that are hard to reproduce, let's merge and see how it goes. 🚀
The test cases work as expected for synced patterns with both titles and no titles.
SiobhyB
deleted the
rnmobile/optional-chaining-for-unsynced-pattern-selector
branch
SiobhyB
pushed a commit
that referenced
this pull request
Aug 17, 2023
This PR adds safety checks for the `title` property within `reusableBlock`. By using optional chaining, the code now gracefully handles scenarios where `title` might be undefined, preventing a TypeError from being thrown.
This was referenced Aug 17, 2023
derekblank
added a commit
that referenced
this pull request
Aug 28, 2023
* Release script: Update react-native-editor version to 1.101.0 * Release script: Update with changes from 'npm run core preios' * Update `react-native-editor` CHANGELOG * Remove incorrect CHANGELOG entry The iOS focus loop will be included in 1.100.2. I've updated the CHANGELOG accordingly. * Release script: Update react-native-editor version to 1.101.1 * Release script: Update with changes from '$PRE_IOS_COMMAND' * fix: Dynamic bottom sheet height (#53608) Stretching this content with flex appears to be necessary after upgrading React Native or refactoring the bottom sheet height animation. Refactor: 0411df1 Upgrade: c2957aa * fix: Optional chaining to handle undefined title (#53721) This PR adds safety checks for the `title` property within `reusableBlock`. By using optional chaining, the code now gracefully handles scenarios where `title` might be undefined, preventing a TypeError from being thrown. * Update CHANGELOG * Release script: Update react-native-editor version to 1.101.2 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Fix Voice Over and assistive keyboards (#53895) * AztecView - Replace usage of TouchableWithoutFeedback with Pressable - This fixes the current React Native regression with VoiceOver and assistive keyboards * Patch React Native's TextInput component to avoid passing the recently introduced accessibilityState prop which causes issues with assistive keyboards * Updates snapshots: Fule, Audio blocks and Search component after changing the AztecView component to use Pressable * Update AztecView's Pressable with changing its accessible prop to false * Update Changelog --------- Co-authored-by: Siobhan <siobhan@automattic.com> Co-authored-by: David Calhoun <github@davidcalhoun.me> Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for wordpress-mobile/gutenberg-mobile#5496 and wordpress-mobile/WordPress-iOS#21083
What?
This PR adds optional chaining to
reusableBlock.titlewithin thebuildReusableBlockInserterItemfunction:gutenberg/packages/block-editor/src/store/selectors.js
Line 1981 in abb51ba
Why?
We've received multiple reports of Gutenberg Mobile crashing with the following error:
The change in this PR is an attempt to fix that crash.
How?
Even after digging deeply into user reports and available logs, attempts to reproduce the crash have been unsuccessful. The main clue we have to go on is that
n.title.rawin the app's generated bundle points to the instance of reusable blocks returned by the inserter.From the checks in place within
getReusableBlocks, we can reasonably infer thatreusableBlockswouldn't be undefined. As such, this PR adds optional chaining to thetitleproperty withinreusableBlock.(Note, the same pattern can be found within the
__experimentalGetReusableBlockTitlefunction in the same file.)By using optional chaining, the code now gracefully handles scenarios where
titlemight be undefined, which should prevent the TypeError from being thrown.Testing Instructions
As the crash isn't easily reproducible, there isn't a straight forward way to ensure this PR fixes it. Instead, the logic of making these change should be verified.
In both the app and on the web, we should also ensure that there are no regressions related to reusable blocks/synced patterns with no titles: