Fonts Library: update properties name from snake case to camel case to match the rest of the properties #53746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
the
[Type] Code Quality
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts-library/class-wp-font-family.php ❔ lib/experimental/fonts-library/class-wp-rest-fonts-library-controller.php ❔ phpunit/fonts-library/class-wp-rest-fonts-library-controller-test.php ❔ phpunit/fonts-library/wpFontFamily/base.php ❔ phpunit/fonts-library/wpFontFamily/getData-test.php ❔ phpunit/fonts-library/wpFontFamily/install-test.php ❔ phpunit/fonts-library/wpFontFamily/uninstall-test.php |
matiasbenedetto
changed the title
hellofromtonya
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Changing the properties makes sense for consistency. Good catch @matiasbenedetto! Changes LGTM 👍
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fonts Library: update properties name from snake case to camel case
download_from_urltodownloadFromUrluploaded_filetouploadedFileWhy?
To match the rest of the properties.