Workflow: Run Lerna directly from GitHub action when publishing to npm targeting WP core #53762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
changed the title
wp/X.Y branch when publishing to npm for WordPress core
gziolo
added
npm Packages
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
gziolo
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
priethor
reviewed
Aug 17, 2023
gziolo
force-pushed
the
fix/wp-branch-npm-publishing
branch
from
224b941
to
e2e3bf2
Compare
priethor
approved these changes
Aug 18, 2023
I discussed it with @tellthemachines, and she plans to test this revised workflow on Monday. I will help with any alternatives in case anything goes wrong. |
|
Unfortunately, the changes aren't enough, and the workflow for the |
gziolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #53628.
Why?
This is exactly what has happened when trying to publish npm packages targeting WordPress 6.3.1 as documented in #53623. For reference the job that failed:
https://github.com/WordPress/gutenberg/actions/runs/5874702589/job/15929869480#step:8:409
Th script got executed with Node.js 16 and npm 8, but the
wp/6.3branch runs on Node.js 14 and npm 6. In addition to that, the branch has strict setting allowing only npm 6.How?
I ended up simplifying the way we publish when targeting WordPress core releases. We run Lerna directly, as it turns out we never update changelog files, nor cherry-pick commits to
trunkas in other scenarios.I also removed all npm scripts that we stopped using:
npm run publish:checknpm run publishnpm run publish:patchI updated documentation to use Lerna commands directly.
Testing Instructions
I don't know what would be the best way to test it without merging. It should just work the next time we have to publish npm packages for WordPress 6.4.x minor release following the instructions:
https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/release.md#wordpress-releases