-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block editor iframe: cache object URL #53804
base: trunk
Are you sure you want to change the base?
Conversation
Size Change: -1 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems legit @ellatrix
I believe that the BLOB store is just another key/value store inside the session. in fact, if we expect most iframes to start with the initial same HTML, we could even examine storing the first HTML that this function gets and then caching the last-given value separately. don't know if that would make sense, but instead of holding onto one value we could hold onto two if we expect that the very first one will come up over and over again.
What?
@dmsnell Do you think this makes a difference?
To test: verify that all frames on the page have the same src.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast