Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Font Collection backend #53816

Closed
wants to merge 52 commits into from
Closed

Font Library: Font Collection backend #53816

wants to merge 52 commits into from

Commits on Aug 18, 2023

  1. Adding Font Collection class

    @matiasbenedetto
    matiasbenedetto committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    79d6af7 View commit details
    Browse the repository at this point in the history

  2. php formatting and linting

    @matiasbenedetto
    matiasbenedetto committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    fd1c967 View commit details
    Browse the repository at this point in the history

  3. Adding tests for collections routes

    @matiasbenedetto
    matiasbenedetto committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    0cfac6c View commit details
    Browse the repository at this point in the history

  4. Adding tests for WP_Font_Collection constructor

    @matiasbenedetto
    matiasbenedetto committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6bb2f8b View commit details
    Browse the repository at this point in the history

  5. adding tests for WP_Font_Collection get_data()

    @matiasbenedetto
    matiasbenedetto committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    4a67d0b View commit details
    Browse the repository at this point in the history

  6. adding tests for WP_Font_Library register_font_collection()

    @matiasbenedetto
    matiasbenedetto committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b26cb63 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. get font collection tests

    @matiasbenedetto
    matiasbenedetto committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0cfddb2 View commit details
    Browse the repository at this point in the history

  2. adding 'wp_' prefix to the 'register_font_collection' filter name

    @matiasbenedetto
    matiasbenedetto committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    7ba6f61 View commit details
    Browse the repository at this point in the history

  3. fix callback name

    @matiasbenedetto
    matiasbenedetto committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    454f9a5 View commit details
    Browse the repository at this point in the history

  4. making class property private

    @matiasbenedetto
    matiasbenedetto committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    932064f View commit details
    Browse the repository at this point in the history

  5. registering filter from font-library.php file

    @matiasbenedetto
    matiasbenedetto committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b184398 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Merge branch 'trunk' into try/font-collections

    @matiasbenedetto
    matiasbenedetto committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6a2dfa0 View commit details
    Browse the repository at this point in the history

  2. removing superfluous comment

    @matiasbenedetto
    matiasbenedetto committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    36ab188 View commit details
    Browse the repository at this point in the history

  3. moving files to according changes in trunk

    @matiasbenedetto
    matiasbenedetto committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ac938c9 View commit details
    Browse the repository at this point in the history

  4. config without a json file should fail

    @matiasbenedetto
    matiasbenedetto committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a9c7b6a View commit details
    Browse the repository at this point in the history

  5. fix property name in tests

    @matiasbenedetto
    matiasbenedetto committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b2deb14 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. name fix 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @matiasbenedetto @hellofromtonya
    matiasbenedetto and hellofromtonya authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4765538 View commit details
    Browse the repository at this point in the history

  2. comment update 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @matiasbenedetto @hellofromtonya
    matiasbenedetto and hellofromtonya authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3fb8b0a View commit details
    Browse the repository at this point in the history

  3. Adds WP_Error to return type

    @hellofromtonya
    hellofromtonya committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3fadd9d View commit details
    Browse the repository at this point in the history

  4. Improves contructor error handling. 

    * Ensures each required param is of the right data type.
* Improves each param check error to include expected data type.
    @hellofromtonya
    hellofromtonya committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bdaacf8 View commit details
    Browse the repository at this point in the history

  5. FontCollection::get_data(): Improves error handling 

    * Rechecking if "data_json_file" exists in the $config property shouldn't be necessary,
  as it's checked in the constructor.

* If the file does not exist, bail out immediately as there's nothing more to do.

* Adds a check and WP_Error for file_get_contents():
file_get_contents() returns false on failure.
If there's nothing in the file, an empty string is returned.
This change checks for both of these conditions and returns a WP_Error if either happens.

* Internationalizes WP_Error error message for consistency in Core.
    @hellofromtonya
    hellofromtonya committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    85fe753 View commit details
    Browse the repository at this point in the history

  6. Removes empty space for wpcs

    @hellofromtonya
    hellofromtonya committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4ae9af6 View commit details
    Browse the repository at this point in the history

  7. adding filter in a simpler way 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @matiasbenedetto @hellofromtonya
    matiasbenedetto and hellofromtonya authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    de053da View commit details
    Browse the repository at this point in the history

  8. micro-optimization 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @matiasbenedetto @hellofromtonya
    matiasbenedetto and hellofromtonya authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    21dfbe3 View commit details
    Browse the repository at this point in the history

  9. reuse WP_Error response instead of creating a new one 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @matiasbenedetto @hellofromtonya
    matiasbenedetto and hellofromtonya authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fb913af View commit details
    Browse the repository at this point in the history

  10. Eliminates try/catch

    @hellofromtonya
    hellofromtonya committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0e6c026 View commit details
    Browse the repository at this point in the history

  11. Revert "Eliminates try/catch" commit 

    This reverts commit 0e6c026.
    @hellofromtonya
    hellofromtonya committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f79212d View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Remove wp_register_font_collection and replace it by a global functio… 

    …n, remove try catch and raise the error if needed
    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4e952e3 View commit details
    Browse the repository at this point in the history

  2. adding function comment and guard agains re-declaration

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    196459a View commit details
    Browse the repository at this point in the history

  3. php format

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a76d943 View commit details
    Browse the repository at this point in the history

  4. fixing docblock coments

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c15b5ae View commit details
    Browse the repository at this point in the history

  5. removing param comment

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    85261b3 View commit details
    Browse the repository at this point in the history

  6. re-adding parameter comment removed by mistake

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ad52829 View commit details
    Browse the repository at this point in the history

  7. format php

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7161ba1 View commit details
    Browse the repository at this point in the history

  8. updating WP_Font_Collection __construct tests

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8402b91 View commit details
    Browse the repository at this point in the history

  9. updating WP_Font_Collection get_data tests

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e0947c9 View commit details
    Browse the repository at this point in the history

  10. updating tests

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    98d52ad View commit details
    Browse the repository at this point in the history

  11. php format

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a6ed145 View commit details
    Browse the repository at this point in the history

  12. array check 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @matiasbenedetto @hellofromtonya
    matiasbenedetto and hellofromtonya authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f8dc1a0 View commit details
    Browse the repository at this point in the history

  13. Documents config array structure

    @hellofromtonya
    hellofromtonya committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4cb5c77 View commit details
    Browse the repository at this point in the history

  14. adding tests for /fonts/collections endpoint

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4b7e5e3 View commit details
    Browse the repository at this point in the history

  15. adding /fonts/collections/<id> endpoint test

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    56607c9 View commit details
    Browse the repository at this point in the history

  16. format

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c928ebe View commit details
    Browse the repository at this point in the history

  17. format

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    aeb42cf View commit details
    Browse the repository at this point in the history

  18. add test for missing collection

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0a98de6 View commit details
    Browse the repository at this point in the history

  19. removing not needed variables

    @matiasbenedetto
    matiasbenedetto committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    46f9fde View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Add more tests and split the test for WP_REST_Font_Library_Controller

    @matiasbenedetto
    matiasbenedetto committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    785262b View commit details
    Browse the repository at this point in the history

  2. lint

    @matiasbenedetto
    matiasbenedetto committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    de12fe7 View commit details
    Browse the repository at this point in the history

  3. try to create dir for tests in CI

    @matiasbenedetto
    matiasbenedetto committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    dc560b8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into try/font-collections

    @matiasbenedetto
    matiasbenedetto committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    60997e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Tests: Core prep 

    * Renamed files to remove `-test` suffix (no longer needed).
* Removed extra empty line before closing the class.
* Used Core's `assertWPError()`.
    @hellofromtonya
    hellofromtonya committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    803a1d1 View commit details
    Browse the repository at this point in the history

  2. Doh I changed the wrong assertion

    @hellofromtonya
    hellofromtonya committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d3935e3 View commit details
    Browse the repository at this point in the history