Patterns: Update empty template part label #53842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
If template parts aren't going to be merged into patterns for at least another release, is it worth making this change and maybe also the details panel on the sidebar nav screen when editing template parts? 
|
|
Size Change: +35 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Aug 21, 2023
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
aaronrobertshaw
force-pushed
the
update/empty-template-part-label
branch
from
1421dc3
to
38c15b5
Compare
|
As the sidebar details panel label was raised in this #53821 (comment), I've pushed a tweak for that to this PR. |
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53821
What?
Updates the empty label for template parts
Why?
Avoids some confusion between template parts and patterns until they are all merged.
How?
Label text is determined based off the current item type.
Testing Instructions
Follow instructions from #53821
Screenshots or screencast