[WIP] Patterns: Explore partial syncing #53887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Feature
aaronrobertshaw
removed
the
[Type] Feature
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/pattern.php ❔ lib/experimental/blocks.php ❔ lib/experimental/editor-settings.php ❔ lib/experiments-page.php ❔ lib/load.php |
aaronrobertshaw
changed the title
|
Size Change: +1.13 kB (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
The pattern block will still have the new dynamic content etc.
aaronrobertshaw
force-pushed
the
try/pattern-attribute-source
branch
from
6f1400c
to
16f5b8d
Compare
Try again
aaronrobertshaw
force-pushed
the
try/pattern-attribute-source
branch
from
36ca103
to
d04f562
Compare
This was referenced Aug 28, 2023
|
Closing this old exploration. Pattern overrides have long since evolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
Related explorations:
What?
Explores possibilities for partially syncing patterns.
At present, this is more Frankenstein than a proper solution. It hacks together a few different approaches.
Some key aspects to note are:
render_blockfilter to process the customized content/attributes and update a block's final markupImportant
This is just a rough prototype hard coded to gain understanding - it is not intended for production implementation
Why?
See #53705 for reasoning
How?
This exploration has been added as a Gutenberg experiment which needs to be opted into to test.
TBA when the approach stabilizes.
Testing Instructions
1. Basic Use Case
metadata.idattribute2. Updating source pattern content
3. Multiple pattern-supported inner blocks
metadata.idattribute4. Image url attribute
Pattern support for heading block has also been added. Test overriding heading content on a per-pattern-instance basis using different levels of headings e.g.
h1-h6.Screenshots or screencast
Screen.Recording.2023-08-23.at.5.26.11.pm.mp4