[Commands]: Add toggle list view command in site editor #53983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
Mamaduka,
youknowriad,
richtabor,
annezazu and
t-hamano
|
Size Change: +43 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
This change looks good to me. However, while testing this PR, I discovered a problem with unintentionally opening the list view even when in Distraction Free mode. I can reproduce this problem in the post editor. Should this issue be addressed in another PR? You can see this bug in the following screencast, just past the 30 second mark. 2909111b5b8a0b563d336b65409c3146.mp4 |
I think we should address it in a different PR and eventually decide how to handle the DFM mode restrictions for every command. Probably in the open sidebar actions or something.. |
t-hamano
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
LGTM!
I think we should address it in a different PR and eventually decide how to handle the DFM mode restrictions for every command. Probably in the open sidebar actions or something..
Indeed it does, I have found that in DFM mode it unintentionally switches not only the list view, but also the sidebar, block inspector, top toolbar, etc 😅
We can address this point in a follow-up PR.
17 tasks
|
I have summarized in #53993 how commands should be handled in DFM mode. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See comment.
This PR adds a command in to toggle the list view in site editor. The respective command for post editor already exists.
Testing Instructions
edit modeopen the commands prompt and try thetoggle list viewcommand.editmode.