Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: merge unsynced into inserter patterns tab and add paging and filtering #54007

Merged
merged 61 commits into from
Sep 14, 2023
Merged

Patterns: merge unsynced into inserter patterns tab and add paging and filtering #54007

merged 61 commits into from
Sep 14, 2023

Commits on Sep 3, 2023

  1. merge synced patterns into patterns tab and add paging

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    fc921a7 View commit details
    Browse the repository at this point in the history

  2. Add sync status back

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    8ca644b View commit details
    Browse the repository at this point in the history

  3. Add back pattern id

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    9be8084 View commit details
    Browse the repository at this point in the history

  4. Add my patterns toggle

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    a098a7b View commit details
    Browse the repository at this point in the history

  5. Remove sync toggle for now

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    fda3f16 View commit details
    Browse the repository at this point in the history

  6. Make sort order same as site editor

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    59a2e0c View commit details
    Browse the repository at this point in the history

  7. Fix bug with paging

    @glendaviesnz
    glendaviesnz committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    f99c31d View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Reset to page one if search filter changes

    @glendaviesnz
    glendaviesnz committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    516341c View commit details
    Browse the repository at this point in the history

  2. Update e2e tests

    @glendaviesnz
    glendaviesnz committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    d4705b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. rename snapshot file

    @glendaviesnz
    glendaviesnz committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    39f33b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Add pattern type filters to insert patterns tab

    @glendaviesnz
    glendaviesnz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    4aa0623 View commit details
    Browse the repository at this point in the history

  2. Add screen reader announcement to indicate number of categories when … 

    …pattern filter changes
    @glendaviesnz
    glendaviesnz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    81165ec View commit details
    Browse the repository at this point in the history

  3. Add aria label to filter select

    @glendaviesnz
    glendaviesnz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    476ef8f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Add filtering to patterns explorer

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ce2aae9 View commit details
    Browse the repository at this point in the history

  2. Simplify filter

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f64f043 View commit details
    Browse the repository at this point in the history

  3. Fix test snapshots

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a8c0785 View commit details
    Browse the repository at this point in the history

  4. Extract filtering logic into a separate method

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    684e57e View commit details
    Browse the repository at this point in the history

  5. Remove redundant fragment

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2ad6587 View commit details
    Browse the repository at this point in the history

  6. Improve readability of pattern filter

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a9c4ae7 View commit details
    Browse the repository at this point in the history

  7. Spread paging props instead of destructuring

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f60beb8 View commit details
    Browse the repository at this point in the history

  8. Switch back to all category when changing filters

    @glendaviesnz
    glendaviesnz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    71271f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Remove duplicate items from inserter and fix icon alignmen

    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c62b4fd View commit details
    Browse the repository at this point in the history

  2. Pattern title layout

    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    de814a6 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    48dcd35 View commit details
    Browse the repository at this point in the history

  4. Switch icon to center alignment

    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bb6cec5 View commit details
    Browse the repository at this point in the history

  5. Make the removal of reusable blocks more targeted to keep selector ba… 

    …ckwards compat
    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    cec2b9a View commit details
    Browse the repository at this point in the history

  6. Revert "Fix unit tests" 

    This reverts commit 48dcd35.
    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    96b9459 View commit details
    Browse the repository at this point in the history

  7. Add show icon labels support to pagination

    @glendaviesnz
    glendaviesnz committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    26f486b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Add the show-icons-label to the body element so it also gets applied … 

    …to modals in the block editor
    @glendaviesnz
    glendaviesnz committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e2292a1 View commit details
    Browse the repository at this point in the history

  2. Switch to using a ref and getScrollContainer to find scroll container

    @glendaviesnz
    glendaviesnz committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2f53ea2 View commit details
    Browse the repository at this point in the history

  3. remove the synced icon and instead use synced colored border on hover

    @glendaviesnz
    glendaviesnz committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    bf74886 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Fix issues with category counts being announced more than once by scr… 

    …een reader
    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b8eadf5 View commit details
    Browse the repository at this point in the history

  2. Revert "remove the synced icon and instead use synced colored border … 

    …on hover"

This reverts commit bf74886.
    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2153343 View commit details
    Browse the repository at this point in the history

  3. Put the icon back

    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1b4f30a View commit details
    Browse the repository at this point in the history

  4. split out the sync toggle to pattern list page

    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    39e5f82 View commit details
    Browse the repository at this point in the history

  5. Tidy up naming

    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    48c36e5 View commit details
    Browse the repository at this point in the history

  6. Set height of select filter

    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    351204d View commit details
    Browse the repository at this point in the history

  7. Reset categories if changing sync filter

    @glendaviesnz
    glendaviesnz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fc40fe7 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Reset category when changing sync filter in patterns explorer

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5199163 View commit details
    Browse the repository at this point in the history

  2. remove sync filter when searching

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6fbc699 View commit details
    Browse the repository at this point in the history

  3. constrain width of sync toggle in pattern explorer

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4487351 View commit details
    Browse the repository at this point in the history

  4. Also set filter height in patterns explorer

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    616066d View commit details
    Browse the repository at this point in the history

  5. Switch to select for sync filter temporarily

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f845d66 View commit details
    Browse the repository at this point in the history

  6. Fix filter width

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    720d3cb View commit details
    Browse the repository at this point in the history

  7. Reset sync filter setting to all each time it is mounted

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0ee4b81 View commit details
    Browse the repository at this point in the history

  8. Revert "Reset sync filter setting to all each time it is mounted" 

    This reverts commit 0ee4b81.
    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8839f7a View commit details
    Browse the repository at this point in the history

  9. Fix issue with all category auto opening when tab first opened

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5951dad View commit details
    Browse the repository at this point in the history

  10. Suggesting wording changes from design review

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3a920f9 View commit details
    Browse the repository at this point in the history

  11. Revert "Fix issue with all category auto opening when tab first opened" 

    This reverts commit 5951dad.
    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    546026f View commit details
    Browse the repository at this point in the history

  12. Remove the all category and have all panel open by default

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    389285f View commit details
    Browse the repository at this point in the history

  13. Remove spoken announcement of category count from hook as currently t… 

    …o much potential for rerender
    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5fd5edc View commit details
    Browse the repository at this point in the history

  14. Move filter above category list

    @glendaviesnz
    glendaviesnz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2cb5cfc View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. map to new array in resolver rather than selector to prevent pointles… 

    …s rerenders
    @glendaviesnz
    glendaviesnz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f69a88f View commit details
    Browse the repository at this point in the history

  2. Revert "Remove spoken announcement of category count from hook as cur… 

    …rently to much potential for rerender"

This reverts commit 5fd5edc.
    @glendaviesnz
    glendaviesnz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    57d54db View commit details
    Browse the repository at this point in the history

  3. Simplify styling

    @jameskoster
    jameskoster committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    275e01e View commit details
    Browse the repository at this point in the history

  4. Add the All categories option back so there is an easy way back to li… 

    …sting all
    @glendaviesnz
    glendaviesnz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f1f4edc View commit details
    Browse the repository at this point in the history

  5. Remove onUnmount category reset

    @glendaviesnz
    glendaviesnz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a37cdd3 View commit details
    Browse the repository at this point in the history

  6. Fix sync filter reset check

    @glendaviesnz
    glendaviesnz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    da77818 View commit details
    Browse the repository at this point in the history

  7. Add no results message

    @glendaviesnz
    glendaviesnz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8b94003 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Reset the category when leaving patterns tab

    @glendaviesnz
    glendaviesnz committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8458d29 View commit details
    Browse the repository at this point in the history

  2. make sure pattern type filters are applied to search results

    @glendaviesnz
    glendaviesnz committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c293dc7 View commit details
    Browse the repository at this point in the history