Make matrix position behave like valign #54050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +247 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
matrix.mp4This seems to be working well for me but I'd appreciate @richtabor or @SaxonF's input as they've been deeper into layout than me recently. |
draganescu
force-pushed
the
try/valign-behavior-matrix
branch
from
8b759ef
to
210d914
Compare
draganescu
force-pushed
the
try/valign-behavior-matrix
branch
from
210d914
to
77fe844
Compare
|
@draganescu thx ! |
30 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50610
I am unsure of this PR, because the matrix alignment is not valign. Should the cover block have a valign prop as well?
###Before
cover-valign-before.mp4
###After
cover-valign-after.mp4