Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Fix social icons block alignment #54100

Merged
merged 3 commits into from
Sep 5, 2023
Merged

[RNMobile] Fix social icons block alignment #54100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb03b75
Fix social icons block alignment
derekblank Aug 31, 2023
0457c9c
Update CHANGELOG
derekblank Sep 1, 2023
7c7563a
Merge remote-tracking branch 'origin' into rnmobile/fix-social-icons-…
derekblank Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/social-link/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ const SocialLinkEdit = ( {
);

return (
<View>
<View style={ styles.container }>
{ isSelected && (
<>
<BlockControls>
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/social-link/editor.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,7 @@
.inactiveIconDark {
background-color: $dark-quaternary;
}

.container {
margin: $block-selected-margin;
}
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ For each user feature we should also add a importance categorization label to i
- [*] Fix horizontal rule style extensions [#53917]
- [*] Add block outline to all Social Link blocks when selected [#54011]
- [*] Columns block - Fix transforming into a Group block crash [#54035]
- [*] Fix Social Icons block alignment [#54100]

## 1.102.1
- [**] Fix Voice Over and assistive keyboards [#53895]
Expand Down
Loading