-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footnotes: enlarge rich text footnote target #54119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +47 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
ellatrix
added
[Block] Footnotes
Affects the Footnotes Block
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
labels
Sep 4, 2023
Just adding the back port label for consideration. |
tellthemachines
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Change LGTM and works well in testing.
Failing unit test seems unrelated so I restarted it.
tellthemachines
pushed a commit
that referenced
this pull request
Sep 5, 2023
tellthemachines
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Footnotes
Affects the Footnotes Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #54015.
Why?
How?
By redirecting clicks on the list item to the rich text element.
Testing Instructions
Clicking anywhere on the list item should focus the rich text element. Clicking on the back link should still work.
Testing Instructions for Keyboard
Screenshots or screencast