Make CircularOptionPicker focus styles resilient to button size changes
#54196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the focus ring around `CircularOptionPicker` options is hard-coded to a specific size. This means that any variation in option size isn't accounted for. This patch updates how the focus ring is styled to make it adapable for differing control sizes.
brookewp
approved these changes
Sep 5, 2023
brookewp
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As per #54156, this PR adjusts the
CircularOptionPickerfocus ring style so as not to be hardcoded to a specific size.Why?
CircularOptionPickerfocus styles don't account for different option sizes, as they are hard-coded to specific dimensions. This means that any variation in option size isn't accounted for.How?
This patch updates how the focus ring is styled to make it adaptable for differing control sizes.
Testing Instructions
navigating.to.colour.options.mov
Navigate to the editor styles colour palette:
Using the keyboard, tab through the various controls until the colour swatch options are highlighted. The focus ring should wrap the swatch, and not look off.
Screenshots or screencast
Before
After