Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Modals to optionally ignore the Close button when determining where to place focus #54296

Closed
wants to merge 26 commits into from
Closed

Allow Modals to optionally ignore the Close button when determining where to place focus #54296

wants to merge 26 commits into from

Commits on Sep 12, 2023

  1. Allow focus to be selected from list of tabbables via callback

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    075e405 View commit details
    Browse the repository at this point in the history

  2. Make all modals ignore Close button when placing focus

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4e13c67 View commit details
    Browse the repository at this point in the history

  3. Remap existing true value to ignore close button

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    79d1ad1 View commit details
    Browse the repository at this point in the history

  4. Optimise firstElement to be biased towards first content element

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ac8c8d4 View commit details
    Browse the repository at this point in the history

  5. Optimise firstElement to be biased towards first content element

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    12d1e33 View commit details
    Browse the repository at this point in the history

  6. Remove redundant comment

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3d51a34 View commit details
    Browse the repository at this point in the history

  7. Make classname stable between usages

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ae180f3 View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    784ea80 View commit details
    Browse the repository at this point in the history

  9. Fix lint by storing function as reference

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c23d284 View commit details
    Browse the repository at this point in the history

  10. Use more accurate type

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fe83a2e View commit details
    Browse the repository at this point in the history

  11. Add CHANGELOG entry for Compose package

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    559cc79 View commit details
    Browse the repository at this point in the history

  12. Improve Modal README 

    Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
    @getdave @ciampo
    getdave and ciampo committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e83fa17 View commit details
    Browse the repository at this point in the history

  13. Optimise firstElement to be biased towards first content element

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    23234d6 View commit details
    Browse the repository at this point in the history

  14. Callback should handle non HTMLElement type

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    22e1d8c View commit details
    Browse the repository at this point in the history

  15. Improve Modal README

    @getdave
    getdave committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    cbbed8d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Update Storybook controls

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fe0f2f1 View commit details
    Browse the repository at this point in the history

  2. Add focus unit test

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ad5ec44 View commit details
    Browse the repository at this point in the history

  3. Mock layout engine to enable focus tests

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7844085 View commit details
    Browse the repository at this point in the history

  4. Include another focusable element to make the test more robust

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    254d71e View commit details
    Browse the repository at this point in the history

  5. Add additional focus management tests

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    65d39bb View commit details
    Browse the repository at this point in the history

  6. Mock once in describe block

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bf58309 View commit details
    Browse the repository at this point in the history

  7. Simplify mocking

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9fec0cf View commit details
    Browse the repository at this point in the history

  8. Update e2e test

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e56f4a3 View commit details
    Browse the repository at this point in the history

  9. Improve comment wording 

    Co-authored-by: Ben Dwyer <ben@scruffian.com>
    @getdave @scruffian
    getdave and scruffian authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f52d193 View commit details
    Browse the repository at this point in the history

  10. Improve another comment

    @getdave
    getdave committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    47f461e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Simplify 

    Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
    @getdave @ciampo
    getdave and ciampo authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3cf68b5 View commit details
    Browse the repository at this point in the history