Site Editor: Clarify the "Entity" message of the snackbar #54333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
t-hamano
added
[Focus] Accessibility (a11y)
|
Size Change: +133 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Thanks for improving these snackbar notices @t-hamano 👍
This tests well for me when renaming or clearing customizations for patterns, template parts, or templates. After forcing errors, the appropriate error message was also displayed.
Nice work 🚢
|
Thanks for the review, @aaronrobertshaw! |
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47886
What?
This PR clarifies the message when Pattern/Template/Template Part are renamed/customization is cleared in the Site Editor.
Why?
"Entity" is a technical term and it is unclear what it refers to.
How?
I have made the process return context-sensitive messages for successful and error-prone processing, instead of using the word Entity.
Testing Instructions
The error message can be confirmed by forcing an error at the beginning of the try statement, as shown below.
Note: The modal does not close when an error occurs and the snack bar is covered by a translucent overlay that I find difficult to see. This issue could be addressed in a follow-up.