-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Remove experimental prefixes from patterns package #54338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
label
Sep 11, 2023
19 tasks
Size Change: -11 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
glendaviesnz
added
[Type] Enhancement
A suggestion for improvement.
[Type] Code Quality
Issues or PRs that relate to code quality
and removed
[Type] Enhancement
A suggestion for improvement.
labels
Sep 11, 2023
aaronrobertshaw
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✅ Creation of synced/unsynced patterns continues to work
✅ Manage and detach pattern options still function as before
I also confirmed these weren't exported and no prefixes were missed in the package.
Nice work ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
__experimental
prefix from the patterns package.Why?
This package currently doesn't have a public API so these are not really.
How?
Removed all occurences of
__experimental
from@wordpress/patterns
packageTesting Instructions
Create pattern
option and make sure this still creates a pattern as expected. Try with both synced and unsynced patternsManage patterns
andDetach pattern
options work as expected