Add manual Server Side Rendering (SSR) to the Interactivity API blocks #54343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Enhancement
24 tasks
|
As the majority of mobile/tablet devices don't show the PDF embed, I've added a CSS media query instead of the |
|
Size Change: +483 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1b0c801. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6146364155
|
luisherranz
approved these changes
Sep 11, 2023
|
I believe it totally makes sense. Thanks for the update 🙂 Merging this now. |
SantosGuillamot
deleted the
update/add-manual-ssr-interactive-blocks
branch
|
Came to this PR while testing Twenty Twent-Four.
This seems to be less than ideal. While testing Twenty Twent-Four I noticed that in the desktop view these attribute are rendered, which is incorrect. Any Accessibility automated checker will flag this as an error.
Screenshot of the current markup: 
These attributes should be entirely omitted when the Navigation block is not rendered within a dialog. I will create a new issue. A small note: |
|
Thanks a lot for taking a look at it and for the detailed feedback 🙂 I believe we can keep the conversation in the issue you opened, and I can work on fixing that. I'll answer you there.
Totally my fault here. I assumed SSR was a more extended term, but you are totally right that I was wrong. I'll take that into account for future issues. |
SantosGuillamot
changed the title
|
For reference, we've reverted the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add manual SSR for the attributes needed in the Interactivity API blocks. Covering the File and the Navigation block.
Why?
The Interactivity API has its own logic to handle the Server Side Rendering (SSR): link. With this, it can translate
data-wp-bind--aria-hidden="context.core.navigation.isOpenand handle the SSR automatically.However, this logic won't be included in WordPress 6.4, while the idea is to include the File and Navigation block using the Interactivity API.
How?
I made sure to define the needed attributes directly in the SSR.
Navigation block
I just had to add the
aria-modal="false"and therole="". The otheraria-expandedattribute in the submenu was already included in the submenu and page list blocks.File block
It seems that the
hiddenattribute was already included: link.In the file block, it shows the preview when it is a Desktop and hides it when it is mobile. This logic seems complicate to replicate in the server, that's why I guess it was added in the first place. I assume we have two options:
Testing Instructions