-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Loop: Use 'Choose pattern' in placeholder for clarity at narrower widths #54449
base: trunk
Are you sure you want to change the base?
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Sounds good to me, thanks for contributing. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
With #63497 aiming the leverage the "Design" panel, it may be more intuitive to use the terminology here: "Choose design". What do you think? |
Sure, that works too. |
What?
In the
QueryPlaceholder
component, update the button text for choosing a pattern to say "Choose pattern" instead of just "Choose."Why?
When the editor canvas has a narrower width, the instructions for the Query Loop block placeholder are hidden, making it unclear what the "Choose" button refers to.
How?
Just changing the text.
Testing Instructions
Screenshots or screencast
Before:
After: