Update RNTAztecView.podspec dependency

[mokagio]

What?

Updates RNTAztecView to use the latest Aztec iOS build wordpress-mobile/AztecEditor-iOS#1376

Why?

To address a bug in iOS 17.

How?

By using ~> 1.19. While this does explicitly use 1.19.9, it will let every client update to it as long as its upstream dependencies are compatible.

Testing Instructions

I'm not sure about this. The Xcode project in the module doesn't build in isolation because it depends on React files that are only available when it's imported. 🤔

Maybe I should create a PR in gutenberg-mobile that uses this Gutenberg version and ensure it works. Update: I created wordpress-mobile/gutenberg-mobile#6201 to test this change works in gutenberg-mobile, when build on top of wordpress-mobile/gutenberg-mobile#6200 which makes this repo the source of truth for RNTAztecView.podspec.

Testing Instructions for Keyboard

N.A.

Screenshots or screencast

N.A.

[github-actions]

Flaky tests detected in 1f05df4.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6197739745
📝 Reported issues:

• [Flaky Test] Should NOT load the view script if the lightbox is disabled in theme.json and in block settings #53802 in /test/e2e/specs/editor/various/behaviors.spec.js
• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[fluiddot]

I wonder if we still need these files 🤔. I presume that if they were pointing to an older version than the one referenced in RNTAztecView.podspec, probably we could deprecate them.

[mokagio]

I agree in that we should drop using Carthage. As you point out, the version was out of sync so either it's not used, something is misconfigured, or we've been lucky.

However, calling carthage it's part of the package.json scripts. I think the reason it's there is to manage the Aztec - Editor dependency without CocoaPods. I think getting rid of it is the work for a dedicated PR.

[fluiddot]

However, calling carthage it's part of the package.json scripts. I think the reason it's there is to manage the Aztec - Editor dependency without CocoaPods. I think getting rid of it is the work for a dedicated PR.

That's interesting. As you pointed out, carthage was probably added as an alternative to CocoaPods. I'm curious if it's actually being used in the iOS Gutenberg demo app. My gut feeling is that it's legacy and we could remove it, but let's tackle this in a separate PR 👍 .

[fluiddot]

@mokagio heads up that I updated the Podfile.lock in 1f05df4 by running the command npm run native preios.

[fluiddot]

LGTM 🎊 !

All E2E tests passed in the GBM PR ✅ .