Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aria-describedBy to communicate border button style and color state #54469

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Use aria-describedBy to communicate border button style and color state #54469

wants to merge 9 commits into from

Commits on Dec 1, 2023

  1. Use aria-describedBy to communicate border button style and color state 

    The previous approach appended a long message to the aria-label to communicate the state of the color selection. This is not desireable, as it changes the accessible name of the button. The accessible name of the button should be stable and brief, and not be used to communicate state. By using aria-describedBy, we can communicate the state in a way that is similarly announced but keeps button name and state separate.
    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a5562bd View commit details
    Browse the repository at this point in the history

  2. Use VisuallyHidden instead of display: none

    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d5ce7dd View commit details
    Browse the repository at this point in the history

  3. Move description element outside of renderToggle

    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b5173c2 View commit details
    Browse the repository at this point in the history

  4. Fix typscript errors

    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    64dd3c8 View commit details
    Browse the repository at this point in the history

  5. Replace ToggleDescribedBy component with inlined

    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    60bd713 View commit details
    Browse the repository at this point in the history

  6. Revert back to display: none method for mounting aria-describedBy con… 

    …tent
    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    19574be View commit details
    Browse the repository at this point in the history

  7. Update tests to reflect new aria-describedby namings

    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    32394a8 View commit details
    Browse the repository at this point in the history

  8. Remove whitespace.

    @jeryj @draganescu
    jeryj authored and draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ddbf1f1 View commit details
    Browse the repository at this point in the history

  9. test updates

    @draganescu
    draganescu committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    9315c6a View commit details
    Browse the repository at this point in the history