Font Face: avoid using non required property as index and use right property to render font face

[matiasbenedetto]

What?

• Fixes font face rendering when a name property is not defined.
• Fix the potential error when rendering font face CSS font family.

Why?

Breaking with fonts families definitions, not including a name property.

How?

• Avoid using non-required property as the index of an associative array.
• Use the right property to render font face. (fontFamily property of a font face).

Testing Instructions

• Activate a theme with font families not containing the name property set.

Todo:

Fix the tests accordingly to these changes.

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Feature] Typography.

Read more about Type labels in Gutenberg.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/fonts/font-face/class-wp-font-face-resolver.php

[github-actions]

Flaky tests detected in 558b2ad.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6237676250
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[hellofromtonya]

I don't think it should use slug. Instead I think it should use fontFamily. Why? slug is not the proper name of the Font Family, but rather is the lowercase and hyphen version of the name. Currently Font Face uses this font-family name in the CSS.

I have PR coming shortly to show it in action.

[hellofromtonya]

PR #54615 uses the fontFamily setting as the fallback to get the name.

[matiasbenedetto]

Sorry for the overlap. Closing in favor of #54610.

[bph]

PR #54615 fixes the issue #54605