Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wp_get_inline_script_tag() in build_dropdown_script_block_core_categories() #54637

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

westonruter
Copy link
Member

See Core-58664. By using wp_get_inline_script_tag() instead of manually constructing script tags, key benefits can be gained, for example being able to use Strict CSP. This change was originally in WordPress/wordpress-develop#4773 but it needed to be upstreamed in Gutenberg.

@westonruter westonruter changed the title Use wp_get_inline_script_tag() in build_dropdown_script_block_core_categories() Use wp_get_inline_script_tag() in build_dropdown_script_block_core_categories() Sep 19, 2023
@westonruter westonruter added [Type] Enhancement A suggestion for improvement. [Block] Categories Affects the Categories Block labels Sep 19, 2023
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @westonruter, LGTM!

@spacedmonkey spacedmonkey self-requested a review September 20, 2023 16:02
@westonruter westonruter enabled auto-merge (squash) September 20, 2023 18:14
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Flaky tests detected in 721d2b4.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6252486724
📝 Reported issues:

@westonruter
Copy link
Member Author

Playwright/E2E tests keep failing. I presume this doesn't have anything to do with the changes in this PR.

@westonruter westonruter merged commit 883ac8e into trunk Sep 21, 2023
49 checks passed
@westonruter westonruter deleted the trac-58664 branch September 21, 2023 17:50
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Categories Affects the Categories Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants