FormTokenField: Add box-sizing reset style and reset default padding
#54734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
changed the title
box-sizing reset style and reset default padding
|
Size Change: 0 B Total Size: 1.62 MB
ℹ️ View Unchanged
|
chad1008
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Thanks @t-hamano, looks good to me! 🚀 🚢
- Inject WordPress style from the top toolbar.
- There should be no change in the appearance of the component.
Just noting for posterity that there is a slight change (2px) in line height of the input when injecting the WordPress styles, but that isn't new to this PR. The same thing happens on trunk so I don't think it should impact merging here.
|
Thanks for the review, @chad1008!
I think this is because injecting WordPress styles changes the font, line height, etc. This is also true for other components, so I would like to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR resolves the following three issues in the
FormTokenFieldcomponent:ulelement on the left sideAs a result, the same problem is resolved for the
ComboBoxControlthat includes this component.Why?
This issue does not occur on the block editor. Because reset styles such as post editor and WP-Admin are applied to these elements.
How?
Added styles to fix unintended appearance.
Testing Instructions
FormTokenFieldandComboBoxControlcomponents, enter characters that match the suggestion list.