Footnotes/Edit Site: fix focus in fn insert #54737
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -13 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 25, 2023
|
I was a bit quick in my approval before, but just to confirm that this is definitely causing issues elsewhere. The issue I'm seeing is with the navigation block that loses its connection, like so:
Compare to trunk, where the connection stays intact:
|
ellatrix
force-pushed
the
fix/fn-block-focus-edit-site
branch
from
ec0a6e5 to
26a67f8
Compare
|
Yes, the cloning was introduces in #27885, which is causing issues for footnotes. Curious if @youknowriad has any thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes the issues but @youknowriad says it's necessary because otherwise it breaks using reusable blocks multiple times. So we need to figure out a different solution here.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast