Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ariakit-based DropdownMenu component #54939

Merged
merged 45 commits into from
Oct 25, 2023
Merged

Add new ariakit-based DropdownMenu component #54939

merged 45 commits into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. Initial version borrowed from experimental branch

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    aba2fd6 View commit details
    Browse the repository at this point in the history

  2. Initial version of DropdownMenu, DropdownMenuItem, DropdownMenuGroup,… 

    … DropdownMenuGroupLabel
    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    79b475f View commit details
    Browse the repository at this point in the history

  3. WIP DropdownMenuCheckboxItem

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a51ebaf View commit details
    Browse the repository at this point in the history

  4. Added separator

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e7767da View commit details
    Browse the repository at this point in the history

  5. Added more props to DropdownMenu

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4c36bfd View commit details
    Browse the repository at this point in the history

  6. Started adding styles

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    784a54a View commit details
    Browse the repository at this point in the history

  7. Improve checkboxes, add radios,

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a912c69 View commit details
    Browse the repository at this point in the history

  8. Reorganize stories

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5b9b8f9 View commit details
    Browse the repository at this point in the history

  9. Only render popover when needed

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c227498 View commit details
    Browse the repository at this point in the history

  10. Refine styles, tweak stories

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7a4100f View commit details
    Browse the repository at this point in the history

  11. Animation

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    27eb68e View commit details
    Browse the repository at this point in the history

  12. Add support for variant context prop

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8edbbba View commit details
    Browse the repository at this point in the history

  13. RTL support

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8fcbd4b View commit details
    Browse the repository at this point in the history

  14. wip tests

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    31436be View commit details
    Browse the repository at this point in the history

  15. Check that submenus triggers are instances of the DropdownMenuItem co… 

    …mponent
    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d16d74d View commit details
    Browse the repository at this point in the history

  16. Cleanup stale TODOs

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    10cbacc View commit details
    Browse the repository at this point in the history

  17. Use WordPressComponentProps type to support standard HTML props in types

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    387a108 View commit details
    Browse the repository at this point in the history

  18. Use unmountOnHide prop

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bd40133 View commit details
    Browse the repository at this point in the history

  19. Update z-index, add hideOnEscape prop, add insidemodal storybook example

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9209d5a View commit details
    Browse the repository at this point in the history

  20. Export as private APIs

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f38ef3f View commit details
    Browse the repository at this point in the history

  21. Add dir and style: direction to wrapper

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2734bce View commit details
    Browse the repository at this point in the history

  22. Add @ariakit/test

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d3ca26c View commit details
    Browse the repository at this point in the history

  23. use @ariakit/test instead of user-event, tweak unit tests

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b804ed7 View commit details
    Browse the repository at this point in the history

  24. Forward name together with value in radio and checkbox change events

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3e89812 View commit details
    Browse the repository at this point in the history

  25. Fix gutter and shift default values

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    262de3d View commit details
    Browse the repository at this point in the history

  26. Tweak storybook examples

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    08c2c24 View commit details
    Browse the repository at this point in the history

  27. Fix missing suffix/prefix styles

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f142666 View commit details
    Browse the repository at this point in the history

  28. Tweak types, add JSDoc

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a3e5625 View commit details
    Browse the repository at this point in the history

  29. Docs manifest

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3b48b2d View commit details
    Browse the repository at this point in the history

  30. Update README (and sync TypeScript JSDocs)

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    50324af View commit details
    Browse the repository at this point in the history

  31. Fix z-index in modal example

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fe38ebf View commit details
    Browse the repository at this point in the history

  32. Focus-visible styles

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3437246 View commit details
    Browse the repository at this point in the history

  33. high contrast mode styles

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9c8807b View commit details
    Browse the repository at this point in the history

  34. Cleanup extra workarounds (all solved directly in ariakit since versi… 

    …on 0.3.5)
    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    97aaa30 View commit details
    Browse the repository at this point in the history

  35. CHANGELOG

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    69742bf View commit details
    Browse the repository at this point in the history

  36. Update README

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    89d49cf View commit details
    Browse the repository at this point in the history

  37. Add unit tests for opening menu by interacting with the trigger via k… 

    …eyboard and uncontrolled check/radio items
    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    650152e View commit details
    Browse the repository at this point in the history

  38. Use seconday button for inside modal story

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    061c9a2 View commit details
    Browse the repository at this point in the history

  39. Allow dropdown menu container to resize and scroll its contents

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b26cd32 View commit details
    Browse the repository at this point in the history

  40. Use a static code snippet for the "Inside modal example

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6fb6e24 View commit details
    Browse the repository at this point in the history

  41. Add docs to the context props

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    52999db View commit details
    Browse the repository at this point in the history

  42. Refine prop descriptions

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6bac80c View commit details
    Browse the repository at this point in the history

  43. Add default false value for defaultOpen prop

    @ciampo
    ciampo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    30d982c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Tweak slotfill example, allow all buttons to hide the menu on click

    @ciampo
    ciampo committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    cf59aa9 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @ciampo
    ciampo committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a5bb3e1 View commit details
    Browse the repository at this point in the history