Migrate 'iframed block editor settings styles' tests to Playwright #55014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
ellatrix
approved these changes
Oct 3, 2023
kevin940726
approved these changes
Oct 4, 2023
|
|
||
| test.describe( 'iframed block editor settings styles', () => { | ||
| test.beforeAll( async ( { requestUtils } ) => { | ||
| await requestUtils.activatePlugin( |
There was a problem hiding this comment.
The original test enables emptytheme here. Do you need to do it here too?
There was a problem hiding this comment.
Not anymore. Since then, all editors have been iframed by default. Unless there's a v2 block or metabox fields enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Closes #54602.
Closes #54462.
PR migrates 'iframed block editor settings styles' tests to Playwright.
Why?
This is a relatively new test and should've been written with Playwright. Ref: #52767.
Testing Instructions