Refactored the consumption of the API to use singular font family data #55073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: -73 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
pbking
force-pushed
the
fix/refactor-font-family-api
branch
from
46d5616 to
bb8e518
Compare
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-rest-font-collections-controller.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php ❔ phpunit/data/fonts/DMSans.woff2 ❔ phpunit/data/fonts/Merriweather.ttf ❔ phpunit/data/fonts/cooper-hewitt.woff ❔ phpunit/data/fonts/gilbert-color.otf ❔ phpunit/tests/fonts/font-library/wpFontCollection/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionController/wpRestFontCollectionsController.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/base.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/createItem.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/deleteItem.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/getItem.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/getItems.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/registerRoutes.php ❔ lib/experimental/fonts/font-library/class-wp-font-family.php ❔ lib/experimental/fonts/font-library/class-wp-font-library.php ❔ lib/experimental/fonts/font-library/font-library.php ❔ lib/load.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/__construct.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getData.php ❔ phpunit/tests/fonts/font-library/wpFontFamily/uninstall.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionController/base.php |
…ated collection IDs
|
Flaky tests detected in 0a60636. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6562584246
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This work changes the client to use the refactored API endpoints currently undergoing change in CORE.
NOTE: This does NOT YET currently include the changed endpoints! To test you MUST be running the version of WordPress CORE from this branch.