[RNMobile] Use UnsupportedBlockDetails component in Missing block
#55133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
Merged
2 tasks
|
Size Change: +1.66 kB (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
I noticed that unit tests related to the Missing block and UBE usage are failing, hence I'm reverting this PR back to draft until I solve them. Seem that those unit tests test against the render tree hierarchy, I'll replace them with integration tests following the testing strategy we applied to other blocks. @dcalhoun I'll let you know when I set the PR back to review, sorry for the noise. |
|
Flaky tests detected in 404518f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6434397587
|
These tests have been superseded by integration tests.
@dcalhoun The failures in unit tests have been addressed in the recent commits. It turned out to be a little bit more complex than I expected 😅. The PR is ready to review, let me know if could take a look, thanks 🙇 ! |
dcalhoun
reviewed
Oct 6, 2023
packages/block-library/src/missing/test/edit-integration.native.js
Outdated
Show resolved
Hide resolved
Thank you very much @dcalhoun for reviewing the PR 🙇 ! I've just reproduced the case of the duplicated note "Note: You must allow WordPress.com login to edit this block in the mobile editor.", so I'll take a deeper look and solve it. |
I reviewed the different cases that modify the description message in the Jetpack app:
When navigating the code, I recalled that the message is also modified and set empty in third-party blocks (e.g. Jetpack blocks) when using the WordPress app:
@dcalhoun The PR should be ready for a re-review, let me know if you could take a look. Thanks 🙇 ! |
dcalhoun
approved these changes
Oct 9, 2023
fluiddot
deleted the
rnmobile/update/missing-block-use-unsupported-block-details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
UnsupportedBlockDetailscomponent in Missing block wordpress-mobile/gutenberg-mobile#6269What?
Following #54382 (comment), the
UnsupportedBlockDetailscomponent has been added to the Missing block and replaced the duplicated logic related to the UBE (Unsupported Block Editor).Why?
Reduces code redundancy and allows unsupported blocks to add extra actions.
How?
The logic related to UBE has been removed and the Missing block is now rendering the unsupported block details bottom sheet via
UnsupportedBlockDetailscomponent.Additionally, a fix
Testing Instructions
Unsupported block can be edited with UBE
Outline is displayed in Classic block
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A