Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: improve UX of dragging the handle when in popover on top of the editor #55149

Merged
merged 23 commits into from
Oct 12, 2023
Merged

ColorPicker: improve UX of dragging the handle when in popover on top of the editor #55149

merged 23 commits into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. ColorPicker: expose drag start / end handlers via context

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d508487 View commit details
    Browse the repository at this point in the history

  2. ColorPicker: remove overflow hidden rule

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d6b7e84 View commit details
    Browse the repository at this point in the history

  3. Dropdown: add some sort of backdrop to capture pointer events

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    64cfbef View commit details
    Browse the repository at this point in the history

  4. Add test story

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    37ff16f View commit details
    Browse the repository at this point in the history

  5. Prevent resizing on color palette's popover, which also triggers over… 

    …flow: hidden
    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d6b387b View commit details
    Browse the repository at this point in the history

  6. Improve backdrop position by using react portal

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    49030c6 View commit details
    Browse the repository at this point in the history

  7. Cleanup

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7e342bf View commit details
    Browse the repository at this point in the history

  8. Aria-hidden

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1c5ae3d View commit details
    Browse the repository at this point in the history

  9. Cleanup

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    54146e2 View commit details
    Browse the repository at this point in the history

  10. Scope querySelector within color picker s container element

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    74e1418 View commit details
    Browse the repository at this point in the history

  11. Listen for drag events also on hue and alpha sliders

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    fc32af5 View commit details
    Browse the repository at this point in the history

  12. Remove temporary styles

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    90147e6 View commit details
    Browse the repository at this point in the history

  13. Remove temporary storybook example

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    fdf61a0 View commit details
    Browse the repository at this point in the history

  14. CHANGELOG

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c9a6923 View commit details
    Browse the repository at this point in the history

  15. Move pointer events trap from Dropdown to Popover component

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2b8f56f View commit details
    Browse the repository at this point in the history

  16. Use state to grab ColorPicker's container element to make sure the co… 

    …mponent re-renders
    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d475284 View commit details
    Browse the repository at this point in the history

  17. Remove overflow:hidden from PaletteEdit component's popover

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e3a7be0 View commit details
    Browse the repository at this point in the history

  18. Update CHANGELOG

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9318bf8 View commit details
    Browse the repository at this point in the history

  19. Remove dead code

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7a4afc1 View commit details
    Browse the repository at this point in the history

  20. Update snapshot

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a065cf8 View commit details
    Browse the repository at this point in the history

  21. Move newly added ColorPicker logic to a separate hook

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e483ec2 View commit details
    Browse the repository at this point in the history

  22. Add inline comment around the resize: false change

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    8c95ac1 View commit details
    Browse the repository at this point in the history

  23. Add more comments

    @ciampo
    ciampo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d008cab View commit details
    Browse the repository at this point in the history